fileinfo portability fixes, stream usages and cleanup, #1
| From: | Pierre Joye | Date: | Mon, 01 Sep 2008 14:40:50 +0000 |
| Subject: | fileinfo portability fixes, stream usages and cleanup, #1 | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-40201@lists.php.net to get a copy of this message | ||
hi all,
Please find the patch here:
http://pierre.libgd.org/patches/fileinfo_stream_cleanup.txt
what it does is:
- add stream support
- removes duplicate codes (can still be better but it can be done later)
- improve portabability (and fixing portability issues in php's stream
will fix fileinfo too)
It has been tested on windows and linux, the tests pass and no leak or
crash has been found.
The next steps (post alpha2) would be:
- add more tests
- finish the code cleanup (the code can be greatly simplified and rely
only on the parser and db loader/compiler instead of the full lib)
- add compression support
Please test, review or comment, the commit is due before alpha2
packaging phase (today).
Cheers,
--
Pierre
http://blog.thepimp.net | http://www.libgd.org