Re: Re: ini-parsing, double quotes, windows in 5.3

From:	Andras	Date:	Sat, 06 Sep 2008 05:08:54 +0000
Subject:	Re: Re: ini-parsing, double quotes, windows in 5.3
References:	1 2 3 4 5 6 7	Groups:	php.internals
Request:	Send a blank email to internals+get-40296@lists.php.net to get a copy of this message

Scott MacVicar wrote:

Stanislav Malyshev wrote:
Hi!
That's exactly why I am reluctant to change what Jani did. It is easier to deal with this minor breakage in 5.3.0 and then have a consistent and clean configuration system. Continuing to add some exceptions while hoping that "no weird things" are used is a bad idea
Do you see any problem with my patch? Any weird things?

I don't really see anything wrong here, it's even a good idea. But! Exceptions like this, that must be documented, are not logical and may cause confusion.

Jani even suggested to add _fatal_ error. The lack of error messages was one of the main arguments against this feature.
No, the main argument is that it would break people's configs, and for no good reason at all (nobody really needs \n's in their paths).
This code is used in parse_ini_file() where it is possible that escapes would be used legitimately, it's not all about paths. Scott -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Andras