Re: [PATCH] add imap_myrights to php_imap
| From: | Diego Woitasen | Date: | Wed, 17 Sep 2008 14:14:46 +0000 |
| Subject: | Re: [PATCH] add imap_myrights to php_imap | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-40541@lists.php.net to get a copy of this message | ||
On Wed, September 17, 2008 12:19 am, Chuck Hagenbuch wrote:
> Quoting Diego Woitasen <diegows@xtech.com.ar>:
>
>> Chuck/Ilia,
>> Could you review this patch? It adds support for MYRIGHTS IMAP
>> command to IMAP PHP extension.
>
> It's been a while since I've worked on this extension. What I can say
> is that I share the concern over using the re-use of the imap_acl_list
> global - why not have a new one for imap_myrights? Also, while adding
> this, any reason not to add LISTRIGHTS too?
No, no reason. I just add MYRIGHTS because it's what I need :). I'll add
LISTRIGHTS too.
>
> Have you checked what c-client versions have support for myrights? Do
> we need a configure check for it?
2000 support it. No configure needed.
>
> Otherwise, looks okay by my unpracticed C eyes, and obviously this
> would benefit Horde/Kolab, so I'd like to see this get in eventually.
Latest Horde/Kolab versions use it, right now.
>
> -chuck
>
So, Who is the mantainer of this extension? or who is the right person to
talk about the inclusion of this patch?
--
Diego Woitasen
XTECH - Soluciones Linux para empresas
(54) 011 5219-0678