Re: OpenSSL random pseudo bytes
| From: | Cristian Rodríguez | Date: | Thu, 25 Sep 2008 21:59:39 +0000 |
| Subject: | Re: OpenSSL random pseudo bytes | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-40692@lists.php.net to get a copy of this message | ||
Scott MacVicar escribió:
> Hi All,
>
> Attached and uploaded [1] is a patch to add the OpenSSL random pseudo
> byte function, at the moment it will return FALSE if the bytes aren't
> considered cryptographically strong, I am however considering making
> this parameter controlled.
>
> Any objections to me applying this to 5.3?
>
> Scott
> --
> [1] - http://whisky.macvicar.net/patches/openssl_prg.patch.txt
>
>
What is the status of this ? I see nothing that can break with this
patch, but I would suggest the function to take the second argument by
value instead of by reference, valid code like
<?php
$activation_code = md5(openssl_random_pseudo_bytes(128, true));
?>
causes a Fatal error: Only variables can be passed by reference...
--
"A computer is like an Old Testament god, with a lot of rules and no
mercy. "
Cristian Rodríguez R.
Platform/OpenSUSE - Core Services
SUSE LINUX Products GmbH
Research & Development
http://www.opensuse.org/
Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc
Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc