[PATCH] Bug #44251
| From: | Tim Steiner | Date: | Mon, 06 Oct 2008 15:40:02 +0000 |
| Subject: | [PATCH] Bug #44251 | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-40864@lists.php.net to get a copy of this message | ||
Greetings,
I have created a patch for Bug #44251 (Question mark and an escaped
singel quote lead to an exception).
The issue was introduced by the fix for Bug #36798 (mysql error when
using named parameters in a query with high ascii). That fix ended up
removing code that would ignore escaped quotes inside of quoted text.
Instead, the parser would treat any escaped quotes as the end of the
quoted string. Therefore, if you have an escaped quote followed by a
question mark, the parse thinks the question mark is a placeholder.
My patch updates the regular expressions used for finding quoted strings
to properly ignore escaped quotes. It also seems to handle the test
case from Bug #36798 correctly.
This is my first patch submission, so I have some questions:
The patch is against 5.2.6. Should it be against a different version?
I had to alter a .re file and a regenerated the .c file with re2c
0.13.5. Should I use a different version and if so where can I get it?
Should I even be submitting the updated .c file?
Thanks!
Tim Steiner