Re: Deprecate define_syslog_variables in 5.3

Hi 2008/10/14 Lukas Kahwe Smith <mls@pooteeweet.org>: > > On 14.10.2008, at 15:03, Markus Fischer wrote: > >> Hi, >> >> Lukas Kahwe Smith wrote: >>> >>> That being said I never used this function or the constants in my code. >>> So is there anyone that does actually use it and has some objection? >> >> Me neither, but in such cases it's probably a good idea to take a look at >> code search machines, e.g. >> >> >> >> http://www.google.com/codesearch?as_q=define_syslog_variables&btnG=Search+Code&hl=en&as_lang=php&as_license_restrict=i&as_license=&as_package=&as_filename=&as_case= >> > > right .. and the interesting thing there is that most of the code is using > the constants even though it calls the function to define the variables > beforehand. the faulty documentation is probably the cause of this. so for > the most part people will just need to remove the function call. I've removed it from HEAD and added an E_DEPRECATED notice on define_syslog_variables() in 5.3. If you're having define_syslog_variables=On in HEAD, it will result in an E_WARNING just like safe_mode, magic_quotes ect. Docs/wiki are updated aswell. > > regards, > Lukas Kahwe Smith > mls@pooteeweet.org > > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > regrads -- Kalle Sommer Nielsen