Re: [PATCH] Bug #46367 - fputcsv does not add the correct newline character on Windows

From:	Lars Strojny	Date:	Wed, 22 Oct 2008 17:36:14 +0000
Subject:	Re: [PATCH] Bug #46367 - fputcsv does not add the correct newline character on Windows
References:	1	Groups:	php.internals
Request:	Send a blank email to internals+get-41321@lists.php.net to get a copy of this message

Hi John, Am Mittwoch, den 22.10.2008, 10:03 -0700 schrieb John Mertic: [...] > Below is a patch to fix this issue; it uses the constant PHP_EOL to > get the correct newline to use on the current platform: Thanks for your patch. A few things to mention, as it is your first patch: please use "diff -ru" to create unified diffs. Also we try to always add tests for the things we fix or create. Would you mind creating a test for the fix you sent to make sure no regression happens in the next n years? Thanks, Lars -- Jabber: lars@strojny.net Weblog: http://usrportage.de

Attachment: [application/pgp-signature] Dies ist ein digital signierter Nachrichtenteil signature.asc