RE: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()

+1 I have no problem with implementing this for NSAPI after the patch is committed to CVS, just keep me informed about this. ----- Uwe Schindler thetaphi@php.net - http://www.php.net NSAPI SAPI developer Bremen, Germany > -----Original Message----- > From: Arnaud LB [mailto:arnaud.lb@gmail.com] On Behalf Of Arnaud Le Blanc > Sent: Sunday, November 09, 2008 10:02 PM > To: internals@lists.php.net > Cc: Christian Schmidt > Subject: Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set > usingheader() > > On Sunday 09 November 2008 19:51:31 Christian Schmidt wrote: > > Stan Vassilev | FM wrote: > > > I suggest header_remove('*') or simply header_remove() /no param/ > > > removes all headers (including the one PHP sets by default), so we can > > > start with a clear state. > > > > I added header_remove('Foo'). header_remove() without arguments removes > > all headers (though Apache still adds some headers that you cannot > remove). > > > > I have tested with apache2handler and cgi. I had to change the signature > > of SAPI header_handler function and sapi_header_struct, so the other > > SAPIs should be updated for this. I am not sure how to test all these? > > Creating a testing environment for all those webservers seems like a > > huge task. > > > > I am not comfortable with the size of this patch, given my understanding > > of the PHP source code and my general C skills, so I am posting this > > patch hoping that somebody will pick it up or help me get it into shape. > > > > It looks good. The signature change is not that bad if it forces all SAPIs > to > be updated and ensures that PHP behaves the same way with all SAPIs. > > It is also possible to add something like header_delete_handler() or > header_handler_ex() to sapi_module_struct if the signature change is to be > avoided. > > Regards, > > Arnaud > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php