Re: Concerning Thies's and Sterling's "Hack"
| From: | Sascha Schumann | Date: | Tue, 26 Aug 2003 03:22:02 +0000 |
| Subject: | Re: Concerning Thies's and Sterling's "Hack" | ||
| References: | 1 2 3 4 5 6 7 8 9 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-4186@lists.php.net to get a copy of this message | ||
> In a stable codebase, where features are not being added
> anymore, performance-oriented hacks are quite appropriate.
are we a bit obsessed with the hacks? :-)
the patch contains some optimizations which don't rely on gcc
features and some fixes. it is prudent to consider these
changes first.
what remains is the execution architecture optimization. ze2
uses function pointers where the patch relies on computed
gotos. the latter was obviously faster to implement, but it
is still unportable. i'd prefer to see it changed to a
ze2-style function pointer array which works with all
compilers. there should not be any difference
performance-wise, especially if -fomit-frame-pointer is used.
- Sascha