Re: Re: PHP 5.2.7 + magic_quotes_gpc broken

On Mon, Dec 8, 2008 at 22:40, Lukas Kahwe Smith <mls@pooteeweet.org> wrote: > > On 08.12.2008, at 16:08, Pierre Joye wrote: > >> On Mon, Dec 8, 2008 at 4:06 PM, Hannes Magnusson >> <hannes.magnusson@gmail.com> wrote: >>> >>> On Mon, Dec 8, 2008 at 15:24, Pierre Joye <pierre.php@gmail.com> wrote: >>>> >>>> hi, >>>> >>>> On Mon, Dec 8, 2008 at 3:15 PM, Ilia Alshanetsky <ilia@prohost.org> >>>> wrote: >>>>> >>>>> Should the 5.3 release be re-branched perhaps as well, since it too has >>>>> this >>>>> problem? >>>> >>>> I do not think it is necessary for 5.3. It is an alpha release after >>>> all and seriously, anyone who plans to move to 5.3.0 and still relies >>>> on magic quotes gpc is likely to have more issues as well. >>> >>> Time to turn it off by default then? >> >> I would even like to drop it (and the other things as well) in 5.3.0 :) > > > the drop was planned for 6.0 for a reason. > i also do not think we need to make a 5.3 release just for this. > lets focus on getting feedback on namespaces and the other changes and have > this fixed on beta1 early 2009. > > adding an E_DEPRECATE (actually i guess we should check the PHP6 NEWS file > for other stuff as well), does make sense. > disabling by default (if not yet done) too. http://phpfi.com/386386 Removed stuff (in 6) disabled by default and throws E_DEPRECATED when activated. set_magic_quotes_runtime() and its evil twin magic_quotes_runtime() already use PHP_DEP_FE/_FALIAS. The getters (get_magic_quotes_gpc() and get_magic_quotes_runtime()) should IMO not spew E_DEPRECATED warnings (and they do not currently, nor after the patch above). Any objections? -Hannes