Re: cvs: php-src(PHP_5_3) /ext/phar/tests ini_set.phpt
| From: | Gregory Beaver | Date: | Wed, 10 Dec 2008 14:28:45 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_3) /ext/phar/tests ini_set.phpt | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-42213@lists.php.net to get a copy of this message | ||
Hannes Magnusson wrote:
> What about 5.2? I thought the extension was supposed to work fine
> there too (at least there are bunch of tests that skip with the reason
> "needs 5.2"). So you have three branches in pecl? HEAD, PHP_5_3 and
> PHP_5_2?
> (Not that fix is required in 5.2, everyone who did try this
> functionality ignored the obvious wrong return value and committed the
> tests as-is and now 5.2 is apparently in
> security/critical-bugfix-mode-only.)
We have 1 branch in pecl. The source uses #ifdef for the 5.2-specific
stuff. So, yes, this test will need to be split into two.
Don't you just love arbitrary changes? :)
Greg