Re: status update for beta1

On Mon, 2009-01-12 at 15:03 +0100, Hannes Magnusson wrote: > On Mon, Jan 12, 2009 at 14:59, Lukas Kahwe Smith <mls@pooteeweet.org> wrote: > > > > On 12.01.2009, at 14:56, Hannes Magnusson wrote: > > > >> Why did the LFS patch never get committed? > > > > LFS = large file support? > > AFAIK there is no patch to commit at this point. > > http://php.markmail.org/message/rhqy2wu5eu5253fm There are problems with this: If PHP is compiled with LFS support other libraries, where we exchange stat pointers and similar stuff, have to be compiled with LFS, too. This affects the Apache SAPIs for instance. So we get some trouble there. I'm fine with using proper types, like off_t in PHP but I won't set -D_LARGEFILE_SOURCE and friends by default. If people want it they might set it themselves, if distributors use LFS apache and other libs they can set it (and be responsible), too, but, in my opinion, this is not to be set by default. Additionally I think it's less an issue than 5 years ago: 64bit systems should be the default by now and I assume it's some time till people want to handle files in the exabyte range with PHP (but who needs more than 64k?) :-) johannes