Re: [PATCH] Bug 47002 - Fields truncated

Oh, I missed one thing. I also had to fix test 001.phpt Attached is the patch for it, which can also be found in the following url: http://felipe.ath.cx/typoon/001.phpt.diff.txt Sorry for the confusion :$ Thanks! Henrique On Wed, Jan 14, 2009 at 11:16 AM, Henrique M. Decaria <typoon@gmail.com>wrote: > Greetings PHP people, > > I have written a patch to resolve the issue mentioned in the subject. Also > I wrote a small test case for it. This patch is to be applied on PHP5_2 CVS. > Still in this matter, I have written a patch for dbase.c (this was based on > Felipe's patch which seems to have been lost) to use zend_parse_parameters > and also to check for the PHP version to define if the arginfo should > receive a static identifier or not. > The patches are attached, and so is the test case. > These files can also be found in the following URLs: > > Patch for the bug: > http://felipe.ath.cx/typoon/dbase_php5.2.9_bug47002.diff > Patch for dbase.c: > http://felipe.ath.cx/typoon/dbase_php5.2.9.diff > Test case for the bug: > http://felipe.ath.cx/typoon/bug47002.phpt > > Currently I am also working on getting the dbase fixed in the PECL > repositories so we can have a release (just finishing writing some test > cases). > > In case there are any doubts or problems, please let me know so I can > verify. > > BTW, I am Gilgamesh on #php.pecl (sometimes shows up as typoon because of > problems with mibbit). So you can also contact me there :) > > Thanks! > > Henrique >

Index: ext/dbase/tests/001.phpt =================================================================== RCS file: /repository/php-src/ext/dbase/tests/Attic/001.phpt,v retrieving revision 1.1.2.2 diff -u -u -w -b -r1.1.2.2 001.phpt --- ext/dbase/tests/001.phpt 25 Feb 2007 23:17:12 -0000 1.1.2.2 +++ ext/dbase/tests/001.phpt 14 Jan 2009 17:34:28 -0000 @@ -55,9 +55,9 @@ Warning: dbase_create(): Unable to create database without fields in %s on line %d bool(false) -Warning: dbase_create(): Expected array as second parameter in %s on line %d -bool(false) +Warning: dbase_create() expects parameter 2 to be array, integer given in %s on line %d +NULL -Warning: dbase_create(): Expected array as second parameter in %s on line %d -bool(false) +Warning: dbase_create() expects parameter 2 to be array, string given in %s on line %d +NULL Done