Re: Method call improvements

JFYI: Method calls increased from 3,2 million to 4 million when I have this patch applied locally. It's a valuable addiction to core! =) Short version: Commit! On Sat, Jan 17, 2009 at 8:26 PM, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: > (for the fun of it, I am CCing Andi, the CTO and senior VP of Zend) > > On Sat, Jan 17, 2009 at 21:17, Marcus Boerger <helly@php.net> wrote: >> Hello Timm, >> >> Friday, January 16, 2009, 9:35:13 PM, you wrote: >> >>> * At [1d], calculate a hash key for the following: >>> - method->name >>> - ce->name >>> - EG(scope) ? EG(scope)->name : "" >>> These are the only variables used for verifying scope and >>> modifiers, and the verification is always going to yield the >>> same result as long as the stay the same. >> >> Aren't we able to bind these at least partially to the function call >> opcode, in case we know they are constant? If all is constsnt we could >> even store the whole lookup in the opcode. Well you'd have to convince >> Zend to do that because os far they have always been against this >> approach. > > Wait what? Wtf? > Why would an opinion from a company matter to us? > > Sure. Dmitry does a kickass good job, but I can guarantee you that > Arnaud, Felipe, Tony and youself could do just as good job. > > If I was king (with m4d skillz) I would fork that "Zend engine", try > to fix the license (which lies, there is no way of "downloading the > engine" from their website) and try to optimize things as much as > possible before it ever hits (almost non-existing) optimizers. > > By saying this kind of things Marcus you make me very scared. You > shouldn't care what Zend, Yahoo, Facebook or whatever company says. If > you think it is the right decision then (quoting Christina Aguilera ;) > ) "Do your thing honey!" > > You were well on-track with your Closures commits, unfortunately that > didn't turn out quite as well neither of us had hoped for, but that is > life. Sometimes your ideas don't work out. Sometimes they do. > It hasn't stopped you so far, so why would it now? > > -Hannes > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Guilherme Blanco - Web Developer CBC - Certified Bindows Consultant Cell Phone: +55 (16) 9215-8480 MSN: guilhermeblanco@hotmail.com URL: http://blog.bisna.com São Paulo - SP/Brazil