Re: towards the next 5.3 release

On 5.2.2009 17:32 Uhr, Johannes Schlüter wrote: > On Wed, 2009-02-04 at 13:12 +0100, David Zülke wrote: >> Am 03.02.2009 um 14:41 schrieb Lukas Kahwe Smith: >> >>> http://bugs.php.net/bug.php?id=47206 - XSLT >> I looked through the CVS logs, could you confirm I understand it right: >> >> The type hint was added in 5.2.6, and will be gone again in 5.2.9, so >> the only PHP releases with DOMDocument type hints there are 5.2.6, >> 5.2.7 and 5.2.8? > > I think independently from what we do in 5.3 we will have > incompatibilities between versions here which can't be worked-around in > userland (I don't consider if (version_compare(...)) { class ... } else > { class ... } a proper workaround) > > So here are three choices: > - The DOMDoument typehint is certainly wrong. > - Adding an interface is lots of additional trouble (user code will > break again, no proper way for users to be 5.2 and 5.3 compatible) > - No typehint, as it is now, #47206 "Expected / to be documented", > incompatible with 5.2.6-5.2.8 but compatible with most other 5.2 > versions > > After reading this thread and some limited private discussion I think > the last option is the best. As one of the maintainer of ext/xsl, here's my +1 on the third option chregu