Memory Leak in ob_get_clean() / ob_get_flush ()
| From: | Christian Seiler | Date: | Wed, 18 Mar 2009 02:15:31 +0000 |
| Subject: | Memory Leak in ob_get_clean() / ob_get_flush () | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-43384@lists.php.net to get a copy of this message | ||
Hi,
When running 'make test' on my system I discovered that
tests/output/ob_start_basic_unerasable_003.phpt and
tests/output/ob_start_basic_unerasable_004.phpt produced memory leaks -
due to the fact that they first fetch the buffer into return_value but
then do RETURN_FALSE if they detect an error and thus leak the copied
buffer.
I attached a patch that fixes that to this mail.
Any objections to me applying this for 5.3 and HEAD? (after 5.3 RC1 when
commits are allowed again of course) Any side-effects I didn't think about?
Regards,
Christian