Re: Re: Bug #40698 Re-use search term in the quicksearch input field

OK, nice idea about that search in comments bug. I try to code it tonight. Next, I found some illogical code in bug tracker source code. For example, there is a file (include/config.php) with mysql access but it is not using, but there are some pages using mysql_connect function followed by mysql_select_db without constants defined in that file. I think there is no reason for this, is there ? 2009/3/27 Kalle Sommer Nielsen <kalle@php.net>: > Hi Josef > > 2009/3/27 Josef Šimánek <retricek@gmail.com>: >> ok, but Mike Bretz wrote that it will be better to mark this bug as >> "Bogus" according to all browsers auto-form completion function. >> This patch was written very fast, without thinking. Next time I spend >> more time to focus on security. >> >> ok, what about these bugs : >> http://bugs.php.net/bug.php?id=46663 >> http://bugs.php.net/bug.php?id=40696 >> >> Will be any improvement to focus on these bugs ? >> Thank you for fast response. > > If you can come up with a good enough patch and idea to resolve the > issue I don't see any reason for why they wouldn't be accepted. Both > of them seems pretty straight forward, for example for #46663, a > checkbox that can be checked to "search comments only" could be added > and then modify the results page to snow a snippet of the comment that > matches. > >> >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > > > > -- > Kalle Sommer Nielsen > kalle@php.net >