Returning NULL when arg parsing fails - was: Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/pcntl pcntl.c /ext/pcntl/tests pcntl_signal.phpt
| From: | Matteo Beccati | Date: | Sat, 28 Mar 2009 16:57:34 +0000 |
| Subject: | Returning NULL when arg parsing fails - was: Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/pcntl pcntl.c /ext/pcntl/tests pcntl_signal.phpt | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-43531@lists.php.net to get a copy of this message | ||
Hi everyone,
Matteo Beccati wrote:
> Antony Dovgal wrote:
>>> MFH:
>>> - Fixed pcntl_signal() returning NULL when passing wrong parameters
>>
>> "Fixed"? Since when standard behavior is "broken"? What's wrong
>> with
>> that?
>
> Sorry about that. I've reverted a few minutes later after Arnaud pointed
> me to the standard behaviour.
Some background: I mostly poked into PDO source files which apparently
are using the wrong behaviour and I assumed that it was the default.
After a quick discussion with Lukas and Antony on IRC, I wrote a small
script to detect how many functions/methods are returning false after
failing to validate the arguments: you 'll find the result for PHP_5_3
attached.
The regex I've used is not perfect, but if you think it's somewhat
accurate we might want to decide fixing in PHP 5.3 as there aren't many
places that need to be fixed.
Cheers
--
Matteo Beccati
OpenX - http://www.openx.org