Re: [PATCH] create_function/zend_eval_string aren't binary-safe
| From: | Johannes Schlüter | Date: | Wed, 03 Jun 2009 20:56:45 +0000 |
| Subject: | Re: [PATCH] create_function/zend_eval_string aren't binary-safe | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-44138@lists.php.net to get a copy of this message | ||
Hi,
On Wed, 2009-06-03 at 13:45 -0500, Matt Wilmas wrote:
> I noticed there are several zend_eval_string() references in PECL sources
> [1], which would be a problem after adding a string length parameter... How
> is that handled? Should the updated function be eval_stringL instead and
> add macros for compatibility?
typical naming would be using eval_string_ex for the version with the
length, but didn't look into it and will be offline till tuesday. Bu if
others review and agree it is a good thing to change. (incl 5.3)
johannes