Re: cvs: php-src /ext/phar/phar pharcommand.inc

Hannes Magnusson wrote: > On Thu, Jun 4, 2009 at 14:31, Hannes Magnusson<bjori@php.net> wrote: > >> On Thu, Jun 4, 2009 at 14:21, Hannes Magnusson <bjori@php.net> wrote: >> >>> bjori Thu Jun 4 12:21:59 2009 UTC >>> >>> Modified files: >>> /php-src/ext/phar/phar pharcommand.inc >>> Log: >>> Fixed creating directory structure when extracting phars >>> >> So I am a bit confused here, are there tests for these PHP files? >> Should there be? >> > > As it turns out, it would actually have been simpler to simply use the > ext itself. > > Is there any reason why that app doesn't use ext/phar? > More importantly, should it be documented with the ext/phar docs? Hi Hannes, In principle, I agree with everything. In practice, I've not been the maintainer of phar.phar, this is Marcus's baby, so I am not familiar with its innards. I have used it in the past month to debug some issues in some generated phars, however, so I do think it's useful. What would be nice, of course, is if it were part of ext/reflection as you say, but this is a post-5.3 issue. In terms of documentation, this is also true, and when I wrote the docs for ext/phar, it didn't even occur to me that this should be documented. As I said before, I have very limited time, is there anyone willing to document this thing? I think it would simply be a question of documenting the commands available. I may have time to do the tests, but that is also tenuous, so if there is a testfester who would like to tackle these, it would be greatly appreciated. Thanks, Greg