Re: ext/standard/crypt_blowfish.c
| From: | Solar Designer | Date: | Mon, 08 Jun 2009 20:09:50 +0000 |
| Subject: | Re: ext/standard/crypt_blowfish.c | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-44208@lists.php.net to get a copy of this message | ||
On Mon, Jun 08, 2009 at 08:22:15PM +0200, Pierre Joye wrote:
> Sadly I do not have the time yet to fix the behavior (remove the
> workaround/BC hack or the on error behavior). If you like to (or have
> the time to :), you can five it a try, that will be very helpful. Or I
> can work on that next week, at the soonest.
I'm afraid I don't have time for much more than commenting on my code,
which I feel somewhat responsible to do. Next week sounds fine to me.
As to removing "the workaround/BC hack", I think this amounts to
removing these lines:
+ if (tmp == '$') break; \
...
+ while (dptr < end)
+ *dptr++ = 0;
+
(as seen in the diff I had posted). The test in crypt.phpt looks fine
to me (that is, it tests for the correct behavior already).
Thanks,
Alexander