RE: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/file bug41874.phpt bug47767.phpt link_win32.phpt TSRM tsrm_virtual_cwd.c
| From: | Andi Gutmans | Date: | Tue, 16 Jun 2009 05:36:48 +0000 |
| Subject: | RE: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/file bug41874.phpt bug47767.phpt link_win32.phpt TSRM tsrm_virtual_cwd.c | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-44291@lists.php.net to get a copy of this message | ||
This really does not look like a very safe commit at this point in the
RC cycle.
These kind of patches are very challenging and can affect behavior of
applications. They are affected by many things incl. user permissions,
CIFS, applications that move files, and more... I am sure you have
tested it quite a bit but my experience with these kind of patches is
that they take a long time to iron out.
My recommendation for RMs is not to accept or push out the release if we
do.
Andi
-----Original Message-----
From: Pierre-Alain Joye [mailto:pajoye@php.net]
Sent: Monday, June 15, 2009 5:14 PM
To: php-cvs@lists.php.net
Subject: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/file
bug41874.phpt bug47767.phpt link_win32.phpt TSRM tsrm_virtual_cwd.c
pajoye Tue Jun 16 00:13:56 2009 UTC
Added files: (Branch: PHP_5_3)
/php-src/ext/standard/tests/file bug47767.phpt
Modified files:
/TSRM tsrm_virtual_cwd.c
/php-src/ext/standard/tests/file bug41874.phpt link_win32.phpt
Log:
- #47767, include_once does not resolve windows symlinks or junctions