Re: header_remove() issues (overly aggressive?)
| From: | Johannes Schlüter | Date: | Tue, 23 Jun 2009 19:49:06 +0000 |
| Subject: | Re: header_remove() issues (overly aggressive?) | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-44445@lists.php.net to get a copy of this message | ||
Hi,
On Tue, 2009-06-23 at 10:55 +0200, Hannes Magnusson wrote:
> While documenting header_remove() I was experimenting a little bit..
>
> If an "empty" argument is passed to the function (empty string, null,
> false,..) the function doesn't do anything, as it checks for
> ZEND_NUM_ARGS() rather then the length of string.. thats a doc issue
> or bug?
I'd say it's ok, "remove the header with the name ''." That's
what it
does.
> Second, it removes even the X-Powered-By header, is that expected?
>
> Third, it removes session and even cookie headers..
> Is that really expected? Just add a big fat warning on the doc page?
It removes all. Should be ok, too, removing the session cookie might
even be considered a "good" feature by some.
Jut my personal opinion though.
johannes