Re: Memory corruption bug

From: Date: Fri, 26 Jun 2009 23:17:00 +0000
Subject: Re: Memory corruption bug
References: 1 2 3  Groups: php.internals 
Request: Send a blank email to internals+get-44500@lists.php.net to get a copy of this message
5.2 is already released so you can commit anyway. For 5.3, I'm not sure (well I am), but wait until Johannes and Lukas are back online please. On Sat, Jun 27, 2009 at 12:15 AM, Andrei Zmievski<andrei@gravitonic.com> wrote: > Stanislav Malyshev wrote: >> >> You just did safe_address in _safe_malloc(nmemb, len, 0) which should have >> called E_ERROR if nmemb*len overflows, so do you need to do it again? >> Leaving a comment about it wouldn't hurt though :) > > Yeah, you're right, but I didn't write the code. :) Regardless, I think this > fix should go into 5.2/5.3 because calloc() advertises memory clearing as > part of its API contract. > > -Andrei > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Pierre http://blog.thepimp.net | http://www.libgd.org

« previous php.internals (#44500) next »