Re: RFC: Type hinting revisited for PHP 5.3

Hi Ilia, On Wed, Jul 1, 2009 at 7:07 PM, Stanislav Malyshev<stas@zend.com> wrote: >> The patch is available here: >> http://ia.gd/patch/type_hint_53.txt > > Technical comment: as this patch changes binary API this shouldn't happen in > 5.3 branch. So maybe it's better to make it for 6. Index: Zend/zend_compile.h =================================================================== RCS file: /repository/ZendEngine2/zend_compile.h,v retrieving revision 1.316.2.8.2.12.2.40 diff -u -p -a -d -u -r1.316.2.8.2.12.2.40 zend_compile.h --- Zend/zend_compile.h 5 Jun 2009 23:20:59 -0000 1.316.2.8.2.12.2.40 +++ Zend/zend_compile.h 1 Jul 2009 16:45:02 -0000 @@ -175,7 +175,7 @@ typedef struct _zend_arg_info { zend_uint name_len; const char *class_name; zend_uint class_name_len; - zend_bool array_type_hint; + zend_uint type_hint; zend_bool allow_null; zend_bool pass_by_reference; zend_bool return_reference; I think you could make this work for 5.3, if it used the old "zend_bool array_type_hint". A zend_bool is 8 bits, so that's plenty. It would be a little bit messy, but I'm fairly confident it could be made work. Thanks, Paul -- Paul Biggar paul.biggar@gmail.com