Re: Patch and RFC for adding DTrace probes to PHP
| From: | David Soria Parra | Date: | Wed, 15 Jul 2009 07:16:18 +0000 |
| Subject: | Re: Patch and RFC for adding DTrace probes to PHP | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-44971@lists.php.net to get a copy of this message | ||
On 2009-07-15, Alexey Zakhlestin <indeyets@gmail.com> wrote:
> The patch is simple and clean. Just 2 notices..
> 1) Zend/zend_dtrace.h file is generated. Are you sure it should be the
> part of patch?
The generated dtrace header on Solaris and MacOS are different.
Therefore people have to generate them during configure and then cannot
copy&paste sources to another machine and build, that's why the provided
zend_dtrace.h includes both variants of the header file and is included
in the patch.