Re: Re: SOAP_MARSHAL_DATETIME (or: bug #44383)
| From: | Dmitry Stogov | Date: | Tue, 28 Jul 2009 13:51:55 +0000 |
| Subject: | Re: Re: SOAP_MARSHAL_DATETIME (or: bug #44383) | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-45121@lists.php.net to get a copy of this message | ||
David Zülke wrote:
> On 28.07.2009, at 13:32, Dmitry Stogov wrote:
>
>> Hi David,
>>
>> I took only a quick look, but I like the patch.
>> In case it doesn't break any tests, it should be committed at least into
>> HEAD. I agree to commit it into 5.3 too, but RMs take the final decision.
>>
>> The only thing I didn't understood - why win32/php_stdint.h is needed.
>
> Ah, yes, that's probably an oversight. Good catch. The headers were
> copy-pasted from some ext/date file :)
>
> Another thing that just occured to me is that we now have a dependency
> on ext/date; I think I had trouble compiling ext/soap as a standalone
> extension like this. Must check again. Any hints?
I think ext/date can't be removed or compiled as shared extension.
If it's the case, the only problem may be with unexported symbols.
Just try to compile/test it as shared extension on Linux and Windows.
Thanks. Dmitry.
> - David
>
>