Changes to php_embed.c/.h break Windows build (revision 286468/bug 48911)
| From: | Garrett Serack | Date: | Thu, 30 Jul 2009 16:15:26 +0000 |
| Subject: | Changes to php_embed.c/.h break Windows build (revision 286468/bug 48911) | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-45148@lists.php.net to get a copy of this message | ||
Howdy,
In response to Bug #48911(http://bugs.php.net/bug.php?id=48911), revision 286468 adds SAPI_API to
int php_embed_init(int argc, char **argv PTSRMLS_DC);
void php_embed_shutdown(TSRMLS_D);
extern sapi_module_struct php_embed_module;
Which breaks building the php5embed on Windows.
On Windows, php5embed is built as a static library, and doesn't need these functions to be
marked as SAPI_API.
Can I suggest we instead use "EMBED_SAPI_API" and insert :
#ifndef PHP_WIN32
#define EMBED_SAPI_API SAPI_API
#else
#define EMBED_SAPI_API
#endif
Garrett