Re: Re: [patch] error masks
| From: | Derick Rethans | Date: | Tue, 25 Aug 2009 12:48:43 +0000 |
| Subject: | Re: Re: [patch] error masks | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-45392@lists.php.net to get a copy of this message | ||
On Mon, 24 Aug 2009, Stanislav Malyshev wrote:
> > If you enable error log you would be able to identify errors, even
> > in legacy code fairly quickly and address them as needed. The speed
> > increase, by Stas' own admission is very minimal here, I would wager
>
> It's not "very minimal". It's not big overall, but it speeds up
> operations affected 300-400%. Can you propose many other changes that
> would speed up any set of opcodes 300% in 10 lines of patch? ;)
Considering that there shouldn't be any errors in the first place, this
is of course a moot point. Sure, 3rd party code (PEAR pcakges?) might
throw errors like crazy on PHP 5, they need to be *fixed* anyway. So if
the minimal overhead of the *whole* application is not close to
affected... I think it'd be a very bad idea to add this extra mask. Yet
another ini setting as well. For the record: I'm against adding this.
regards,
Derick
--
http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org
twitter: @derickr