Re: Fix for 49148 (combination of stream_get_line and fseek does not work correctly)
| From: | Stanislav Malyshev | Date: | Wed, 02 Sep 2009 21:14:46 +0000 |
| Subject: | Re: Fix for 49148 (combination of stream_get_line and fseek does not work correctly) | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-45451@lists.php.net to get a copy of this message | ||
Hi!
I thought I'd run this by folks first before committing, as it impacts streams, which are pretty important :D . It passes the current tests, and I wrote test for it too. (below).I notice that the bug says it happens only on Windows, while the fix doesn't have anything specific for windows. Could you explain why it is so? Another question is why stream->eof is not set in this case on Windows - shouldn't it be? -- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com