Re: shebang skipping in 5.3.0

It's very legit to use with CGI since you might not be able to run PHP any other way. So this is definately a bug, CGI should handle it the same as CLI. The bug report clearly explains it too: http://bugs.php.net/bug.php?id=49182 --Jani Andi Gutmans wrote:

Shebang is for command line scripts (php-cli). It does not make sense to support it for Web server scripts. It just adds unnecessary code/complexity to that code base. Removing the support from php-cgi was really a remnant of the old days when cli and cgi were the same SAPI. I think we are better off this way. Andi

-----Original Message----- From: Joey Smith [mailto:joey@joeysmith.com] Sent: Friday, September 04, 2009 1:35 AM To: internals@lists.php.net Subject: Re: [PHP-DEV] shebang skipping in 5.3.0 I definitely had the wrong changeset - sorry, Nuno. :) Looks like maybe 273177 is the problem child. http://tinyurl.com/lewcft On Fri, Sep 04, 2009 at 09:25:52AM +0100, Scott MacVicar wrote:

On 4 Sep 2009, at 09:16, Joey Smith <joey@joeysmith.com> wrote:

I can understand not having the 'shebang skipping' code in both the SAPI *and* the scanner, but we probably need to have it in at least ONE of them. :) Per his email[1] almost a year ago, Dmitry removed the shebang line check from sapi/cgi/cgi_main.c in changeset 264153, saying: Removed shebang line check from CGI sapi (it is

       checked by scanner)

In http://tinyurl.com/me8528 (changeset 262275), nlopess removed the code from the scanner. Oops?

What's the problem your having? The skip code is still there just in

a

different bit. Scott -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php