Re: [sapi] PHP-FPM (FastCGI Process Manager), by Andrei Nigmatulin - upstream Y/n?
| From: | Jani Taskinen | Date: | Wed, 09 Sep 2009 08:01:16 +0000 |
| Subject: | Re: [sapi] PHP-FPM (FastCGI Process Manager), by Andrei Nigmatulin - upstream Y/n? | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-45536@lists.php.net to get a copy of this message | ||
On 09/09/2009 10:53 AM, Stanislav Malyshev wrote:
Very good point. And I did consider only merging the _good_ parts of this thing. I haven't had time to check the code yet at all (quite busy at work right now) but there are some stuff it does we haven't generally considered the "job of PHP" before. The list of them is here: http://php-fpm.org/What_is_PHP-FPM --JaniAs separate SAPI, wouldn't it duplicate a LOT of code, basically for nothing? I'd rather see the good parts of this merged into the one-and-only sapi/cgi/ code instead of creating yet another SAPI nobody maintains for real.If the code will be really the same exactly, then maybe it can be just reused (e.g. functions, etc.)? If not, then somewhat similar code I don't think is a problem if it's maintained, and if it's not then better have unmaintaned separate SAPI then unmaintained pieces of code inside of one of most used SAPIs :) In general, I'd consider changing sapi/cgi adding new potentially unstable hode rather high-risk, unless it can be very well isolated. sapi/cgi runs quite a lot of code...