Re: RFC: php_config --extra_includes

hi! On Sun, Oct 11, 2009 at 10:05 AM, shire <shire@tekrat.com> wrote: > > Currently we have an open bug #16809 > (http://pecl.php.net/bugs/bug.php?id=16809&edit=1) in APC where we're unable > to find the pcre.h header file as it's not in our include path when a user > compiles PHP with the --enable-pcre=<some include path>.  This is because > the include path the user provides isn't made available in INCLUDES in the > extension (APC) when compiled as a shared library using phpize. > > I've come up with the following solution, but want feedback/other options > before I commit.  Essentially I've made use of the EXTRA_INCLUDES that's > included in INCLUDES, but not really used much of anywhere AFAIK.  I've also > added the autoconf macro PHP_ADD_EXTRA_INCLUDE that mirrors the > PHP_ADD_INCLUDE behavior, as well as the --extra_includes option to > php-config.  This way extensions can provide additional include paths that > they depend on for extensions that may in-turn be dependent on their header > files. > > http://tekrat.com/downloads/bits/extra_includes.php5.3.patch Would it be not more correct to test if the bundled pcre is used or not. And detect the pcre header if the system pcre is used? Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org