Re: [patch] mysql_warning_count() for ext/mysql

Ulf Wendel schreef:

Jille Timmermans schrieb:

I have 'implemented' MySQL's mysql_warning_count() function. ( http://dev.mysql.com/doc/refman/5.1/en/mysql-warning-count.html ) mysql_warning_count() is available in MySQL's C-api in >3.23, >4.1 and >5

I am not a big fan of adding anything to ext/mysql that is not security relevant or mission critical. mysql_warning_count() is a convenience function. It is performance 'critical': Without this function I will have to query 'SHOW WARNINGS' after every query, which won't be good for the performance.

Let ext/mysql run out and use ext/mysqli instead. ext/mysqli is around since PHP 5.0 = 2004 = 5 years. It can be considered as faily stable. It is as easy to use as ext/mysql. Performance is virtually identical. ext/mysqli didn't have persistent connections till 5.3; this made it impossible for me to switch to it at the time we had to decide.

Only ext/mysqli gives you access to all functionality of MySQL 4.1 and above, e.g. charset and prepared statements. Why would you hide functionality from people when you get a patch, and all that has to be done is commit it? I'm pretty sure it won't break anything.

I see no reasons for updating ext/mysql when there is a successor (for so long). It should have been included a long time ago, IMHO.

-- Jille

Ulf