Re: Patch for bug #49936
| From: | Felipe Pena | Date: | Sun, 15 Nov 2009 20:36:34 +0000 |
| Subject: | Re: Patch for bug #49936 | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-46043@lists.php.net to get a copy of this message | ||
Hi Pierrick,
2009/11/13 Pierrick Charron <pierrick@webstart.fr>
> Hi,
>
> I created a patch for the bug #49936.
>
> The problem was due to the new way to manage references of stream context.
> The patch increase the refcount of the context when it's assigned to a
> stream (in the method php_stream_context_set).
> A zend_list_delete is already called on the context when the stream is
> destroyed to do the opposit.
>
> There is two different version of the patch. The better one (because
> it's not using TSRMLS_FETCH) modify the php_stream_context_set which
> may be used by some of the PECL extensions. And of course the second
> version of the patch use TSRMLS_FETCH to avoid signature modification.
>
> http://www.adoy.net/php/stream-nofetch.diff
> http://www.adoy.net/php/stream-fetch.diff
>
> I also wrote two phpt for this bug :
>
> http://www.adoy.net/php/phpt/bug49936-phpt.tgz
>
> Thanks for feedbacks.
> Pierrick
>
>
>
Committed! Thanks for the patch again!
--
Regards,
Felipe Pena