Re: [PATCH] - Improving multi-threaded performance by propagating TSRMLS_C

hi johannes, > I'm not too happy about hiding the TSRM macro with another macro as it > makes reading the code harder. When writing code I want to spot easily > whether my function needs TSRM or not. > > When adding such a macro that should be done for making the code better > readable, not worse. > I'm currently working on getting rid of this change and instead explicitly passing TSRMLS_C. >> where >> +#define TSRMLS_DC1   TSRMLS_D, >> +#define TSRMLS_CC1   TSRMLS_C, > > Are there more cases of this? - If zend_get_parameters is the only case multi_convert_to_long_ex multi_convert_to_double_ex multi_convert_to_string_ex are the other use cases of this. thanks, arvi