Re: [PATCH] bug when requesting a non existing file

Committed, thanks. I guess we can also move from the list to private mails and IRC (EFNet, #php.pecl) as I'm sure not many of internals@ subscribers are interested in FPM patches at the moment. On 16.12.2009 20:13, Jérôme Loyet wrote: > There is a bug in fpm_main.c. After accepting a request, it's > initialized and SG(request_info).path_translated must be set. If it's > not set (NULL) nothing is done and the php_execute_script is called > without having php_fopen_primary_script() called. It causes segfault: > > 1- call several time a non existant page (/noexistent.php) > 2- call several time an existant page (/test.php) > 3- call a non existant page (/noexistent.php) --> the child handling > this request segfaults > > The solution is to return a 404 when SG(request_info).path_translated is NULL. > > By the way, it corrects a non desired feature (bug ?) as well. When > calling a non existent value, it returns a 404 with the following > message > <br /> > <b>Warning</b>: Unknown: Filename cannot be empty in <b>Unknown</b> > on line <b>0</b><br /> > <br /> > <b>Fatal error</b>: Unknown: Failed opening required '' > (include_path='.:/usr/local/lib/php') in <b>Unknown</b> on line > <b>0</b><br /> > > ++ Jerome > -- Wbr, Antony Dovgal --- http://pinba.org - realtime statistics for PHP