Re: ext/pgsql and trunk
| From: | Matteo Beccati | Date: | Wed, 30 Dec 2009 17:39:29 +0000 |
| Subject: | Re: ext/pgsql and trunk | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-46573@lists.php.net to get a copy of this message | ||
Hi Ilia,
Cc-ing internals
Il 30/12/2009 15:39, Ilia Alshanetsky ha scritto:
On 2009-12-30, at 4:45, Matteo Beccati <php@beccati.com> wrote:Thanks for your quick reply. I've committed the changes. Now it'd be great to get someone to review the changeset just to make sure I didn't make gross mistakes. Cheers -- Matteo Beccati Development & Consulting - http://www.beccati.com/Hi Ilia & Marcus, I'm sending this to both of you because I don't know who's the current maintainer of ext/pgsql (is the EXTENSIONS file up to date?) I've managed to fix ext/pgsql in trunk so that it is unicode compliant. All the tests are now passing, but code coverage isn't great so there are probably things I could have missed. What do you think, should I proceed committing the changes?That's great, definately go ahead and commit the changes.