Re: Debian PHP patches

Jani Taskinen wrote: > 16.1.2010 20:10, Raphael Geissert wrote: >> Some of the other patches include: >> libdb_is_-ldb > > Why? Potentially breaks things when you assume db/ being correct place.. Do you have an example of any actual case? > >> 115-autoconf_ftbfs.patch > > Hell no. You're breaking the configure again with this crap. I already > reverted the idiocy once, don't even think about doing this shit again. > PHP configure works properly only with autoconf-2.13 which was the last > working autoconf. Can you tell me what exactly we are breaking? divert calls should only be used internally by autoconf and the, apparently useless, usage of them in php makes it fail to build with any other autoconf. > >> fix_broken_upstream_tests.patch > > The soap thing seems ok. > > But why are you disabling > ext/standard/tests/general_functions/phpinfo.phpt ?? That test passes fine > for me everywhere. The patch says: > > test suite's handling of "%s" is incompatible with this test" > > Eh? I've never seen that test actually work but I don't remember the details right now. Will check it next time and report. > >> Which should all be merged > > And next time, please include direct links to the patches, makes easier to > follow these and comment on them. :) Ok. Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net