Re: PATCH for bug #47199
| From: | Sokolov Evgeniy | Date: | Tue, 09 Feb 2010 15:11:14 +0000 |
| Subject: | Re: PATCH for bug #47199 | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-46968@lists.php.net to get a copy of this message | ||
> did you really run this test and was it successful? - doesn't looklike
> for me.
I just run "php tests/27_bug47199.phpt" and check the result output.
Is this correct way?
>> Property changes on: tests/27_bug47199.phpt
> This isn't needed.
Okey, I just use previous test in this dir as example. Remove this property
> And please also add a link to the patch to the bug report
Can it be link on pastebin.org? For example http://pastebin.org/88880
2010/2/9 Johannes Schlüter <johannes@php.net>:
> Евгений,
>
> thanks for the patch.I didn't fully review it but I wonder about a
> thing:
>
> On Tue, 2010-02-09 at 16:27 +0500, Соколов Евгений wrote:
>> Index: tests/27_bug47199.phpt
>> ===================================================================
>> --- tests/27_bug47199.phpt (revision 0)
>> +++ tests/27_bug47199.phpt (revision 0)
> [...9
>> +--EXPECTF--
>> +DELETE FROM <?php echo $tbl_name;?> WHERE null_field IS NULL AND
>> not_null_field=2;
>> +Done
>> \ No newline at end of file
>
> did you really run this test and was it successful? - doesn't looklike
> for me.
>
>> Property changes on: tests/27_bug47199.phpt
>> ___________________________________________________________________
>> Added: svn:executable
>> + *
>
> This isn't needed.
>
> And please also add a link to the patch to the bug report, so it won't
> get lost, which can happen on a mailing list too easy.
>
> johannes
>
>
best regards