Re: Patch for ext/openssl to support CN_match with asterisk
| From: | Pierre Joye | Date: | Sat, 20 Feb 2010 23:05:54 +0000 |
| Subject: | Re: Patch for ext/openssl to support CN_match with asterisk | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-47005@lists.php.net to get a copy of this message | ||
hi,
Is it not suppose to work already? As your patch basically does what
is done earlier in the code if match fails. If there is a bug in this
area, we should fix instead of adding the same thing later :)
I will check this issue next week.
Btw, there is no chance to get this in 5.2.13 or 5.3.2 at this stage,
it is too late in the process.
Thanks for your work!
Cheers,
On Sat, Feb 20, 2010 at 8:56 PM, Bostjan Skufca <bostjan@a2o.si> wrote:
> Hi!
>
> I've created a patch that enables PHP to do "limited wildcard
> matching" if CN_match option in stream context is specified as
> '*.example.org'.
> Also I have filled a bug report for this, here:
> http://bugs.php.net/bug.php?id=51100
>
> Patch is here:
> http://source.a2o.si/php/php-ext-openssl-CN_match-wildcard.diff
>
> It was made against 5.2.12 but I checked it with SVN:
> - for 5.2 branch the offset is only +6 lines
> - for trunk it is cca +800 lines
>
> Can you include it in 5.2.13 release and 5.3? I know the former is
> already in RC stage but this does can't break anything I believe.
>
> Best regards,
> b.
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org