Re: Re: svn: /php/php-src/ branches/PHP_5_2/NEWS branches/PHP_5_2/ext/filter/logical_filters.c branches/PHP_5_3/NEWS
branches/PHP_5_3/ext/filter/logical_filters.c trunk/ext/filter/logical_filters.c

On Fri, Apr 2, 2010 at 10:22 PM, Martin Jansen <martin@divbyzero.net> wrote: > On 02.04.10 19:56, Rasmus Lerdorf wrote: >> rasmus                                   Fri, 02 Apr 2010 17:56:37 +0000 >> >> Revision: >> http://svn.php.net/viewvc?view=revision&revision=297350 >> >> Log: >> Update the FILTER_VALIDATE_EMAIL filter to fix bug #49576 > > I'm referring to the following comment: > >> +      * However, it is not identical.  I changed it to only consider routeable >> +      * addresses as valid.  Michael's regex considers a@b a valid address >> +      * which conflicts with section 2.3.5 of RFC 5321 which states that: > > Is this actually correct behavior?  The top-level domain for the Vatican > e.g. has MX records, so at least theoretically pope@va is a valid and > routeable email address, no matter what RFC 5321 states. The recuring question is what we want to do in filter (url or email). Do we want to follow the RFC or do we want to valid using what's the users expect to be valid (which can be completely different)? Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org