Re: What gruntwork needs to be done
| From: | Martin Jansen | Date: | Wed, 07 Apr 2010 06:15:24 +0000 |
| Subject: | Re: What gruntwork needs to be done | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-47813@lists.php.net to get a copy of this message | ||
On 6.4.2010 19:54, Rasmus Lerdorf wrote:
> On 04/06/2010 10:47 AM, Scott MacVicar wrote:
>> http://whisky.macvicar.net/patches/utf8-string.diff.txt
>
> My only issue with this is that it essentially duplicates the utf8 part
> of get_next_char() from html.c. I'd like to see cs parsing in one place
> instead of spread out all over the code tree. The get_next_char()
> function also supports other charsets, so we could have a more generic
> cs_validate() function along with utf8_validate().
Shouldn't this be str_cs_validate() then? Or has the plan been
abandoned to group functions into logical groups by their prefix?
- Martin