Re: Fixes for parse_url, bug 50563
| From: | Pierre Joye | Date: | Mon, 24 May 2010 11:30:59 +0000 |
| Subject: | Re: Fixes for parse_url, bug 50563 | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-48427@lists.php.net to get a copy of this message | ||
hi,
I will apply the patch to trunk later today as it seems that we have
no objection for the patch itself. The proposal to add more
information on failure can be implemented later, if someone fills
motivated enough to do it.
Cheers,
--
Pierre
On Sat, May 22, 2010 at 5:28 PM, Pierre Joye <pierre.php@gmail.com> wrote:
> hi,
>
> On Sat, May 22, 2010 at 4:42 PM, Ilia Alshanetsky <ilia@prohost.org> wrote:
>> Instead of removing a warning, why not add an additional parameter to the
>> function that would instruct it to silence warning messages on parse
>> failure?
>
> What are the actual usefulness of these warnings? I see absolutely no
> need to keep them.
>
> However, it would be useful to have an optional parameter to get why
> an URL actually failed. But that can be done later.
>
> Cheers,
> --
> Pierre
>
> @pierrejoye | http://blog.thepimp.net |
> http://www.libgd.org
>
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org