Re: Remove variable function and method calls
| From: | Reindl Harald | Date: | Thu, 22 Jul 2010 23:47:45 +0000 |
| Subject: | Re: Remove variable function and method calls | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-49112@lists.php.net to get a copy of this message | ||
Am 23.07.2010 01:36, schrieb Karoly Negyesi:
>> public function __get($subclass)
>> {
>> $include_file = CONTENTLOUNGE_BASEDIR . 'api_' . $subclass . '.php';
>> $class_name = 'cl_' . $subclass;
>> $this->$subclass = new $class_name();
>> return $this->$subclass;
>> }
>
> And this code contains no variable function call. You mixed it up with
> a variable class name perhaps? That's why I want to nuke it...
You said "Remove variable function and method calls"
There are sure thousands of nice implementations you like to kill
because you do not like such code - So do not write such code
but stop to try kill things that are making php strong in so many
cases!
I do not waste time to search throw-away-code which was only used one
time to convert / import wahtever some htings with quick&dirty-implementation
where it does not matter if this is beautiful, it has to run once and save
time instead of doing something manually
And yes there are sue cases to swithc an internal method-call by
some parameters - the question is not if this is good on all places
where such things are used - the question is why will you kill it?