Re: Annotation RFC + Patch

Hi Pierrick, Guilherme 2010/8/25 Pierrick Charron <pierrick@webstart.fr>: > I'm here to propose a new feature in PHP: Annotations. > A patch is already available with 54 tests for the moment[2]. > > I worked together with Guilherme Blanco to make this support happen in > a fresh PHP SVN trunk checkout. > Please review, comment and provide feedback! I think it's a very > useful support and may benefit users a lot. After looking over both the RFC and patch I think its a great feature, and its something I remember Guilherme have bugged about since 5.3's development stage ;-). The syntax for one is decent, by having it in the code rather than a source code comment and its somewhat compatible with that in C#. The only thing I could see missing in the patch, although its a minor thing is to dump Annotations when doing something like: Reflection::export(new Reflection...(...)); and your small TODO in ReflectionAnnotation::__construct() :) But I'm a +1 for merging this into trunk, as it will without doubt get improved as we go, like with Traits. -- regards, Kalle Sommer Nielsen kalle@php.net