Re: Re: svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/standard/file.c branches/PHP_5_3/ext/standard/file.h
branches/PHP_5_3/ext/standard/ftp_fopen_wrapper.c branches/PHP_5_3/ext/standard/http_fopen_wrapper.c branch
| From: | Gustavo Lopes | Date: | Sat, 30 Oct 2010 16:14:04 +0000 |
| Subject: | Re: Re: svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/standard/file.c branches/PHP_5_3/ext/standard/file.h branches/PHP_5_3/ext/standard/ftp_fopen_wrapper.c branches/PHP_5_3/ext/standard/http_fopen_wrapper.c branch |
||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-50014@lists.php.net to get a copy of this message | ||
On Sat, 30 Oct 2010 16:56:36 +0100, Pierre Joye <pierre.php@gmail.com> wrote:
This directive is documented only to be used with FTP.The documentation was wrong, and has also been fixed. According to the bug report, this directive has been used for http for the last 8 years.
Yes it would be nice to fully support the HTTP RFC, but not by making this implementation more ugly. Also new features should go to trunk. I suggest to actually fix the reported bug and do the right changes and additions in trunk.I repeat, there were no additions here. The only bug in that report was that cfg_get_string was being used to retrieve the value of the ini directive, which is wrong because then PHP doesn't know anything about the directive expect by putting it in the hash table that results from ini parsing. In particular, ini_set cannot then be used to change the value of the directive through the script. In fact, after removing these usages of cfg_get_string, only two usages remain in php-src, both in PDO. Regards -- Gustavo Lopes