Re: [PATCH] fix extract w.r.t GLOBALS again
| From: | Felipe Pena | Date: | Sat, 20 Nov 2010 00:14:43 +0000 |
| Subject: | Re: [PATCH] fix extract w.r.t GLOBALS again | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-50398@lists.php.net to get a copy of this message | ||
Hi Chris,
2010/11/19 Chris Stockton <chrisstocktonaz@gmail.com>
> On Fri, Nov 19, 2010 at 8:43 AM, Joe Orton <jorton@redhat.com> wrote:
> > The check to prevent extract() overwriting $GLOBALS got broken at some
> > point - here's a fix:
>
> I remember http://bugs.php.net/47409 for this some time ago and
> seeing
> it marked applied. After taking a peak it looks like the patch in the
> bug report was ignored. One more reason why I stopped contributing I
> guess.
>
>
The fix committed to the related bug was just like your patch, except that
you did the right sizeof() - 1.
Then as you see, we need contributions... making patches... testing fixes...
reviewing fixes...
As it's said in the bugsweb... "Help us make PHP better." :)
--
Regards,
Felipe Pena