Re: --enable-zend-multibyte
| From: | Dmitry Stogov | Date: | Tue, 23 Nov 2010 10:47:05 +0000 |
| Subject: | Re: --enable-zend-multibyte | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-50432@lists.php.net to get a copy of this message | ||
Gustavo Lopes wrote:
On Tue, 23 Nov 2010 09:34:49 -0000, Dmitry Stogov <dmitry@zend.com> wrote:Thank you for comments. I'll care about both issues. Thanks. Dmitry.hi, I've prepared the patch which completely removes compile-time --enable-zend-multibyte configuration directive. The configuration can be changed at run-tume using zend.multibyte=0/1. The patch also fixes Unicode detection for phar archives. I would like to commit it on Thursday.Just two comments: * You have a line commented out with // (line #443) * The phar fix autodetection is wrong. You look for __HALT_COMPILER, but you should be looking for __HALT_COMPILER();, __halt_compiler(); or any casing variation. __HALT_COMPILER, by itself, does nothing (see http://lxr.php.net/opengrok/xref/PHP_TRUNK/Zend/zend_language_parser.y#219 ). See the patches in #53199.
Also remember to close #42396 once you commit a proper fix. Other than that, no objections.