Re: [PATCH][ZE2] zend_highlight.c <font> change

On Tue, 2003-10-28 at 15:10, GPHemsley@aol.com wrote: > In your diff, you have this line: + zend_printf("<span style=\"color: > %s\";>\n", last_color); > > There's a semicolon (;) in the <span> tag (marked in red, if > available). If that was meant to be part of the style attribute (like > style=\"color: %s;\">), then it is in the wrong place. And also, if > that is the place it's supposed to be, then you missed one on > the + zend_printf("<span style=\"color: %s\">", last_color); line. Yes quite right on missing the last semicolon. Truly having it there or not is personal preference. My preference is to use semicolons at the end of each style definition, but since in this context the user can't add any additional styles then it makes sense to omit it. -- Regards, -Lisa <Vix ulla tam iniqua pax, quin bello vel aequissimo sit potior>

Attachment: [application/pgp-signature] This is a digitally signed message part signature.asc